MB-71383: Define logging functions for GPU - #92
Closed
capemox wants to merge 2 commits into
Closed
Conversation
capemox
requested review from
CascadingRadium,
Likith101,
Thejas-bhat,
abhinavdangeti,
Copilot and
maneuvertomars
April 14, 2026 04:26
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new (exported) callback types and associated string keys intended to let callers hook logging/handling for GPU-related vector search errors.
Changes:
- Introduces
GPUToCPUCloneErrorCallbackandGPUErrorCallbackfunction types. - Adds two new internal/config keys for registering those callbacks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
capemox
marked this pull request as ready for review
April 14, 2026 04:34
Member
|
As mentioned in my zapx comment, please avoid doing this segment config usage for stats collection. |
github-project-automation
Bot
moved this from In Progress
to Done
in GPU-Accelerated Vector Search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines two new callbacks for GPU related errors:
GPUToCPUCloneErrorCallback: called when the clone to GPU failsGPUErrorCallback: called when other generic GPU errors occur